Open
Conversation
The new CLI will call commands from outside the package. The import statements needed to be reworked. Not proud of the solution, but I cannot think of something better now.
With the setup file we can install the cli command `geohc` and build eggs and wheels.
Move all the models.py ... commands to the geohc cli and add deprecation warnings.
Need to fix loose ends: - DB exists, but still needs db-create - check import statements - fix env setting for GHC_SETTINGS_CONF - check non-docker build - update docs
TODO: test the create-instance, double check os.path things
Member
|
@borrob again great effort! See you even thought of Docker build. @tomkralidis will you be able to review? |
tomkralidis
requested changes
Jan 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings an unified CLI to control GeoHealthCheck (fix #189).
I introduced
clickto take control over all the cli-commands and I was able to completely phase outpaver(paveris still available, but I marked it as deprecated). To keep an overview, I kept all of the cli commands in the filegeohc_cli.py. I also introduced asetup.pyfile in order to install GHC with a simplepip install .. I believe we can now also upload it to pypi.@tomkralidis : can you review the
setup.pyfile since I assumed you would be the maintainer.The CLI command now allow for:
geohc create-instance,geohc db-create,geohc db-adduser -u rob -p mypass -e e@mail.com -r admin, andgeohc --help.